Skip to content

refactor(@angular-devkit/build-angular): reduce usage of @angular-devkit/core types#27242

Merged
clydin merged 1 commit intoangular:mainfrom
clydin:application/cleanup-3
Mar 11, 2024
Merged

refactor(@angular-devkit/build-angular): reduce usage of @angular-devkit/core types#27242
clydin merged 1 commit intoangular:mainfrom
clydin:application/cleanup-3

Conversation

@clydin
Copy link
Copy Markdown
Member

@clydin clydin commented Mar 8, 2024

Logging types are now based on the BuilderContext's type instead of the @angular-devkit/core type. This reduces the need to directly depend on this package while also allowing the builder logging type to diverge if needed.

@clydin clydin added the target: minor This PR is targeted for the next minor release label Mar 8, 2024
@clydin clydin changed the title refactor(@angular-devkit/build-angular): reduce usage of @angular-devkit/core usage refactor(@angular-devkit/build-angular): reduce usage of @angular-devkit/core types Mar 8, 2024
…kit/core types

Logging types are now based on the BuilderContext's type instead of the
`@angular-devkit/core` type. This reduces the need to directly depend
on this package while also allowing the builder logging type to diverge
if needed. The two usages of the BaseException type which is a small
wrapper around Error have also been removed.
@clydin clydin force-pushed the application/cleanup-3 branch from da9b242 to b0cd93c Compare March 8, 2024 22:17
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 9, 2024
@clydin clydin requested a review from alan-agius4 March 9, 2024 03:12
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 11, 2024
@clydin clydin merged commit 560ec40 into angular:main Mar 11, 2024
@clydin clydin deleted the application/cleanup-3 branch March 11, 2024 14:06
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants